internal: (studio) enable studio to access the protocol database with a new connection #31502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
ryanm/chore/full-snapshot-threaded
|
| Run status |
|
| Run duration | 11m 35s |
| Commit |
|
| Committer | Ryan Manuel |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
672
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
37.81%
|
|
|---|---|
|
Untested elements
|
125
|
|
Tested elements
|
76
|
Accessibility
92.18%
|
|
|---|---|
|
Failed rules
|
3 critical
7 serious
1 moderate
1 minor
|
|
Failed elements
|
525
|
ryanthemanuel
changed the title
AtofStryker
approved these changes
Apr 15, 2025
ryanthemanuel
commented
Apr 17, 2025
ryanthemanuel
commented
Apr 17, 2025
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
In order to not block the main thread with full snapshot generation, we are going to move this logic to a worker thread. In order to access the protocol database from within a worker thread, we need to provide the path to the database rather than the database itself. In addition, we need to provide enough information to properly load in
better-sqlite3in the worker thread and make sure it's properly accessible in the binary.Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?