ci: use containers matrix name in github actions workflow #789
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the GitHub Actions matrix variable name from
machines
tocontainers
in the workflow using-action.yml for consistency with the Cypress documentation (docs.cypress.io) and the Cypress GitHub Action repo (github.com/cypress-io/github-action). It also expands on the in-line explanation about the matrix arraycontainers
.Reason for change
Although the workflow previously explained that the items in the matrix did not matter, it has led to some confusion in new users concerning the matrix variable name
machines
used by the example GitHub Action workflow using-action.yml:The Cypress documentation (docs.cypress.io) and the Cypress GitHub Action repo (github.com/cypress-io/github-action) consistently use the variable
containers
as the name of the matrix array which defines how many parallel jobs are run when recording into Cypress Cloud.
The matrix variable name
containers
is simply a dummy name, which does not affect how the workflow runs, since the variable name is not used in any substitution. For comparison, in the jobparallel-runs-across-platforms
, the matrix variable nameos
and the array contentsos: ['ubuntu-22.04', 'windows-latest', 'macos-latest']
are significant and these are used in substitution.References