-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency actions/upload-artifact to version v4 🌟 #780
Conversation
See the guidelines for reviewing dependency updates for info on how to review dependency update PRs. |
✅ Deploy Preview for cypress-example-kitchensink ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Passing run #27364 ↗︎
Details:
Review all test suite changes for PR #780 ↗︎ |
Passing run #27366 ↗︎
Details:
Review all test suite changes for PR #780 ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems these changes will break for multiple screenshot updates. actions/upload-artifact@6a5077f#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5L101
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be safe to merge. We're already using this version (actions/upload-artifact@v4
) in https://github.com/cypress-io/github-action.
Normally actions/upload-artifact@v4
doesn't even get invoked here. It's skipped when there are no test errors, so you actually have to go out of your way to introduce a test failure in order to test actions/upload-artifact@v4
.
|
🎉 This PR is included in version 2.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR contains the following updates:
v3
->v4
Release Notes
actions/upload-artifact (actions/upload-artifact)
v4
Compare Source
Configuration
📅 Schedule: Branch creation - "after 2am and before 3am on saturday" in timezone America/New_York, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.