Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugins.json add @dankieu/cypress-sq #6097

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

testervippro
Copy link

Hi i create plugin to connect with database

Copy link

netlify bot commented Feb 3, 2025

👷 Deploy request for cypress-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 5513692

@CLAassistant
Copy link

CLAassistant commented Feb 3, 2025

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link
Collaborator

@testervippro testervippro marked this pull request as draft February 3, 2025 09:11
@testervippro testervippro marked this pull request as ready for review February 3, 2025 09:11
@MikeMcC399

This comment was marked as resolved.

@testervippro
Copy link
Author

okay
Are you the same person as the npm user dankieu7979? , yep , that my own acc
The related package.json includes no repository key, so if users install the plugin they will not be able to report any issues they find

package.json shows "cypress": "^12.0.0" so it is not compatible with the latest major version Cypress 14.x

There is no CI test shown
=> i will update
Thanks

@testervippro
Copy link
Author

Hi @MikeMcC399 i just updated it

@MikeMcC399

This comment was marked as resolved.

src/data/plugins.json Outdated Show resolved Hide resolved
@jennifer-shehane jennifer-shehane self-requested a review February 3, 2025 14:53
@testervippro testervippro marked this pull request as draft February 3, 2025 15:06
@testervippro testervippro marked this pull request as ready for review February 3, 2025 15:06
@testervippro
Copy link
Author

sr i push wrong branh, now it should be correct @MikeMcC399 @JJ

@MikeMcC399

This comment was marked as resolved.

@testervippro
Copy link
Author

testervippro commented Feb 3, 2025

okay , i see i also update @dankieu/cmd to 14.0.1 @MikeMcC399

@MikeMcC399

This comment was marked as resolved.

@testervippro
Copy link
Author

i need demo run with all database in ci env ?

@MikeMcC399

This comment was marked as resolved.

@MikeMcC399

This comment was marked as resolved.

@testervippro
Copy link
Author

Hi @MikeMcC399 i have update docker-compose to install fast db and update ci in github env, it's run ok
pls help me review it again

@MikeMcC399
Copy link
Contributor

MikeMcC399 commented Feb 4, 2025

@testervippro

i have update docker-compose to install fast db and update ci in github env, it's run ok pls help me review it again

I don't have any more comments for you to make changes. I expect that @jennifer-shehane will now review.

There is a Cypress technical community on Discord

Discord chat (click on button)

and I don't know if you are already a member. If you are, or you want to join, you can also advertise your plugin in the Promote channel there. Several members recently have been asking about sql.

Edit: Perhaps you are the Discord user 8386? In which case you already mentioned your plugin in https://discord.com/channels/755913899261296641/1326594725456773251/1333428700057702410

@testervippro
Copy link
Author

okay thank for your time
hi @JJ can you help me review it , look like i have some mistake , and now it shoud ok

@testervippro
Copy link
Author

this is first time i contribute haha

@testervippro
Copy link
Author

Edit: Perhaps you are the Discord user 8386? In which case you already mentioned your plugin in => yep ,it's lead to this plugin haha

@testervippro testervippro marked this pull request as draft February 5, 2025 09:00
@testervippro testervippro marked this pull request as ready for review February 5, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants