Skip to content

Conversation

@emilmilanov
Copy link
Contributor

image

@changeset-bot
Copy link

changeset-bot bot commented Dec 12, 2025

🦋 Changeset detected

Latest commit: 63fee41

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@cypress-design/constants-button Minor
@cypress-design/react-button Minor
@cypress-design/vue-button Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 12, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
cypress-design Ready Ready Preview Dec 15, 2025 11:45am

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right!

@cypress
Copy link

cypress bot commented Dec 12, 2025

cypress-design    Run #3277

Run Properties:  status check passed Passed #3277  •  git commit 84553ee7ce ℹ️: Merge 63fee41158895ad1cc17306990e6b79bd7f0fc50 into feaba4ee360d641117f874c8caab...
Project cypress-design
Branch Review button-purple-dark-mode
Run status status check passed Passed #3277
Run duration 02m 22s
Commit git commit 84553ee7ce ℹ️: Merge 63fee41158895ad1cc17306990e6b79bd7f0fc50 into feaba4ee360d641117f874c8caab...
Committer Emil Milanov
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 2
View all changes introduced in this branch ↗︎

Warning

No Report: Something went wrong and we could not generate a report for the Application Quality products.

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't the highlight in the PR different from the figma
Screenshot 2025-12-12 at 1 37 25 PM
Screenshot 2025-12-12 at 1 37 48 PM

@emilmilanov
Copy link
Contributor Author

isn't the highlight in the PR different from the figma Screenshot 2025-12-12 at 1 37 25 PM Screenshot 2025-12-12 at 1 37 48 PM

This looks different because we're comparing focus state in code and active state in Figma.
I'm attaching proper comparison.

image image

@emilmilanov emilmilanov merged commit b8eb190 into main Dec 15, 2025
21 of 22 checks passed
@emilmilanov emilmilanov deleted the button-purple-dark-mode branch December 15, 2025 14:39
@cypress
Copy link

cypress bot commented Dec 15, 2025

cypress-design    Run #3280

Run Properties:  status check passed Passed #3280  •  git commit b8eb190c3d: Purple dark mode button (#637)
Project cypress-design
Branch Review main
Run status status check passed Passed #3280
Run duration 02m 10s
Commit git commit b8eb190c3d: Purple dark mode button (#637)
Committer Emil Milanov
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1
View all changes introduced in this branch ↗︎
UI Coverage  0%
  Untested elements 9  
  Tested elements 0  
Accessibility  94.24%
  Failed rules  0 critical   1 serious   3 moderate   0 minor
  Failed elements 8  

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants