Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed behavior of EntityFactory #509

Merged
merged 4 commits into from
Mar 2, 2025
Merged

Changed behavior of EntityFactory #509

merged 4 commits into from
Mar 2, 2025

Conversation

roxblnfk
Copy link
Member

@roxblnfk roxblnfk commented Feb 27, 2025

It doesn't overwrite entity fields, but does it with unresolved relations

🔍 What was changed

  • Separated RoleResolver service
  • Changed behavior of EntityFactory:
    It doesn't overwrite entity fields now, but does it with unresolved relations

🤔 Why?

📝 Checklist

  • Closes #
  • How was this tested:
    • Tested manually
    • Unit tests added

📃 Documentation

It doesn't overwrite entity fields, but does it with unresolved relations
@roxblnfk roxblnfk added magic Structural changes, new features, performance. type:feature New feature. labels Feb 27, 2025
@roxblnfk roxblnfk added this to the 2.10.x milestone Feb 27, 2025
@roxblnfk roxblnfk force-pushed the new-entity-factory branch 4 times, most recently from 4a85d5e to f0b8479 Compare February 28, 2025 11:03
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.65%. Comparing base (f2d32fb) to head (cc5fc55).
Report is 6 commits behind head on 2.x.

Files with missing lines Patch % Lines
src/Service/Implementation/RoleResolver.php 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                2.x     #509   +/-   ##
=========================================
  Coverage     91.65%   91.65%           
- Complexity     1814     1816    +2     
=========================================
  Files           115      116    +1     
  Lines          4647     4661   +14     
=========================================
+ Hits           4259     4272   +13     
- Misses          388      389    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roxblnfk roxblnfk merged commit 44eaeb0 into 2.x Mar 2, 2025
30 checks passed
@roxblnfk roxblnfk deleted the new-entity-factory branch March 2, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
magic Structural changes, new features, performance. type:feature New feature.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant