Stop tagging the web image :latest - #423
Merged
Merged
Conversation
Nothing reads it. CYBER_DOJO_WEB_TAG is the short sha, set by
bin/echo_env_vars.sh, and docker-compose.yml names the image
${CYBER_DOJO_WEB_IMAGE}:${CYBER_DOJO_WEB_TAG}. No sibling repo refers to
cyberdojo/web:latest either, so the comment in remove_old_images.sh
saying local tooling refers to it described nothing.
Keeping it had a cost. remove_all_but_current exempted :latest, so the
build it last pointed at survived every later build's cleanup, and the
tag moving to each new build left the previous image behind untagged.
Removing the exemption lets those go, and this build stays protected by
its own sha tag, which is what names it everywhere.
cyberdojo/web:<sha> stays: sibling repos name the web image with the
dockerhub name their env-vars carry rather than the ECR one.
Also fixes the mismatch message in assert_web_image_has_sha_env_var,
which named <image>:latest, a tag that no longer exists.
This is the change made in runner as drop-the-runner-latest-tag, applied
to web, which had two latest tags rather than one.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing reads it. CYBER_DOJO_WEB_TAG is the short sha, set by
bin/echo_env_vars.sh, and docker-compose.yml names the image
${CYBER_DOJO_WEB_IMAGE}:${CYBER_DOJO_WEB_TAG}. No sibling repo refers to
cyberdojo/web:latest either, so the comment in remove_old_images.sh
saying local tooling refers to it described nothing.
Keeping it had a cost. remove_all_but_current exempted :latest, so the
build it last pointed at survived every later build's cleanup, and the
tag moving to each new build left the previous image behind untagged.
Removing the exemption lets those go, and this build stays protected by
its own sha tag, which is what names it everywhere.
cyberdojo/web: stays: sibling repos name the web image with the
dockerhub name their env-vars carry rather than the ECR one.
Also fixes the mismatch message in assert_web_image_has_sha_env_var,![]()
:latest, a tag that no longer exists.
which named
This is the change made in runner as drop-the-runner-latest-tag, applied
to web, which had two latest tags rather than one.
Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com