Stop tagging the runner image :latest - #299
Merged
Merged
Conversation
JonJagger
commented
Aug 28, 2026
Member
:latest earned its keep when remove_old_images ran before the build: the
removal kept that one tag and nothing else, so it was what held the previous
image alive. Now that removal runs after the build, the keep-list also carries
this commit's tag, and that tag names the image just built. :latest points at
the same image, so it protects nothing the sha tag was not already protecting.
Neither reason given for keeping it holds. There is no cache-from anywhere in
the repo, and BuildKit's layer cache is not keyed by a tag, so :latest does
nothing for the build cache. Nor does local tooling reach it: creator, web,
dashboard, nginx and commander all name the runner
${CYBER_DOJO_RUNNER_IMAGE}:${CYBER_DOJO_RUNNER_TAG}, and versioner supplies a
pinned sha for that tag rather than latest. CI never refers to it either, and
check_args rejects 'server' inside CI, so this path does not run there.
cyberdojo/runner:<sha> stays. Sibling repos carry the dockerhub name in their
env-vars, not the ECR one, so a locally built runner still has to answer to it.
The dropped clause was already dead for the client image, which compose only
ever tags with the sha.
docs/profiling/time_docker_run_phases.sh names the tag in its help text and now
shows how the tag is derived. docs/multiple container properties-tests-failing
.txt still says :latest, and is left alone: it transcribes a debugging session
that was run against that tag, and rewriting the command would misreport what
produced the output below it.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.