Improve phpdoc #228
Merged
Improve phpdoc #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Omg... should have rebased, there probably isn't a button for it in Github UI? |
|
do an interactive rebase against master ( |
|
That has to wait until tomorrow, I'm afraid. I know what to do, but I'm lacking the tools to do it properly right now. |
SvenRtbg
force-pushed
the
improve_phpdoc
branch
from
64b5f1c to
5e06c3a
Compare
SvenRtbg
force-pushed
the
improve_phpdoc
branch
from
5e06c3a to
fa0cef4
Compare
|
Thank you Sven. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates some phpdoc annotations based on executing PHPStan level 5.
I intentionally didn't include PHPStan in the build pipeline as that's a matter of preference for the right tool.