Skip to content

Conversation

jcpunk
Copy link
Collaborator

@jcpunk jcpunk commented Sep 19, 2025

Fixes #18

jcpunk added a commit to jcpunk/prometheus-cvmfs that referenced this pull request Sep 19, 2025
jcpunk added a commit to jcpunk/prometheus-cvmfs that referenced this pull request Sep 19, 2025
@jcpunk jcpunk mentioned this pull request Sep 19, 2025
@vvolkl
Copy link
Contributor

vvolkl commented Sep 24, 2025

Hmm, like this it will unfortunately only work with cvmfs versions older than 2.13.2 - with newer versions of cvmfs the script uses the output of cvmfs_talk -i <repo> metrics prometheus unchanged, in order to avoid the overhead of calling cvmfs_talk for each metric individually. So we'd have to update as well https://github.com/cvmfs/cvmfs/blob/devel/cvmfs/talk.cc#L926, cut another cvmfs release and add yet another version handling case to this script. This doesn't sound too appealing, maybe there is some kind of post-processing that we can do instead?

@jcpunk
Copy link
Collaborator Author

jcpunk commented Oct 7, 2025

I figured out a way to rework the patch to be cleaner. In theory this should work for all forms of the exporter.

@jcpunk jcpunk requested a review from vvolkl October 7, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Add (optional) timestamp for metrics

2 participants