Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscription managament documentation updated with FAQ #7739

Merged
merged 31 commits into from
Apr 23, 2024
Merged

Subscription managament documentation updated with FAQ #7739

merged 31 commits into from
Apr 23, 2024

Conversation

mdacoca
Copy link
Contributor

@mdacoca mdacoca commented Apr 8, 2024

Motivation and context

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@mdacoca mdacoca marked this pull request as ready for review April 8, 2024 10:25
@mdacoca mdacoca requested a review from nmanovic April 8, 2024 10:26
@bsekachev
Copy link
Member

bsekachev commented Apr 17, 2024 •
edited
Loading

Shall we add a link to refund policy to FAQ?

@mdacoca
Copy link
Contributor Author

mdacoca commented Apr 18, 2024

Shall we add a link to refund policy to FAQ?

added

@mdacoca mdacoca added the documentation Documentation should be updated label Apr 23, 2024
nmanovic
nmanovic requested changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please try to replace all jpg images by png ones inside the article? It looks like PNG screenshots are quite small and it is better to use lossless format if an image less than 100kb. What do you think?

@nmanovic
Copy link
Contributor 

$ du -h site/content/en/images/cancel-solo.png
32K	site/content/en/images/cancel-solo.png
$ du -h site/content/en/images/add-invoice.jpg
28K	site/content/en/images/add-invoice.jpg
$ du -h site/content/en/images/add-vat.png
84K	site/content/en/images/add-vat.png

nmanovic
nmanovic approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmanovic nmanovic merged commit d4ffaa5 into develop Apr 23, 2024
13 checks passed
@nmanovic nmanovic deleted the ma/vat-and-tax branch April 23, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsekachev bsekachev bsekachev left review comments

@nmanovic nmanovic nmanovic approved these changes

Assignees
No one assigned
Labels
documentation Documentation should be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdacoca @bsekachev @nmanovic