Adds realtime through SSE #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BernardGatt
requested review from
Copilot and
a team
and removed request for
a team
BernardGatt
commented
May 15, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR implements real-time message handling using Server-Sent Events (SSE) alongside the existing polling approach.
- Adds SSE-related flags and methods to
settings.jsfor tracking usage and connection activity. - Extends
queue-service.jsto detect SSE support from response headers, store the flag, and provide an SSE endpoint. - Updates
queue-manager.jsto use SSE where enabled, including setup and teardown of anEventSource.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/services/settings.js | New local-store keys and methods to track SSE usage/activity. |
| src/services/queue-service.js | Reads x-cio-use-sse header, defines setQueueUseSSE, and stubs getQueueSSEEndpoint. |
| src/managers/queue-manager.js | Implements setupSSEQueueListener, stopSSEListener, and conditional SSE vs. polling logic. |
Comments suppressed due to low confidence (1)
src/services/settings.js:36
- [nitpick] The method name
useSSEreturns a boolean; consider renaming toisSSEEnabledorisUsingSSEfor clearer intent.
useSSE: function() {
src/services/queue-service.js
Outdated
| function setQueueUseSSE(response) { | ||
| if (response && response.headers) { | ||
| var useSSE = response.headers["x-cio-use-sse"]; | ||
| useSSE && useSSE.toLowerCase() === "true" ? settings.setUseSSEFlag(true) : settings.setUseSSEFlag(false); |
There was a problem hiding this comment.
[nitpick] The ternary with && is hard to read. Simplify to settings.setUseSSEFlag(useSSE?.toLowerCase() === 'true') for clarity.
Suggested change
| useSSE && useSSE.toLowerCase() === "true" ? settings.setUseSSEFlag(true) : settings.setUseSSEFlag(false); | |
| settings.setUseSSEFlag(useSSE?.toLowerCase() === "true"); |
Copilot uses AI. Check for mistakes.
added 6 commits
May 16, 2025 10:47
* master: Bump version to 3.15.7 Add support for mailto on same page links Added origin check for message events
…ere modal overlays were getting stuck.
clabland
approved these changes
Jun 9, 2025
| sseSource.addEventListener("error", async (event) => { | ||
| log("SSE error received:", event); | ||
| stopSSEListener(); |
There was a problem hiding this comment.
Will this switch back to polling?
There was a problem hiding this comment.
Yeah, stopSSEListener has settings.setUseSSEFlag(false);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: INAPP-13259