Added exitClick handling #79
Conversation
| { | ||
| persistent = true | ||
| } | ||
| if (message.properties.gist.exitClick) |
There was a problem hiding this comment.
Do you ever think about pulling out the properties as a local variable? I ask because when I see a ton of references like this, the cognitive load of reading all of this can be lessened with some vars that skip reading a ton of dot notation.
Sometimes (don't know if this is still a JS issue) there is even a performance hit at scale with dot notation that you can shortcut with a local var, though a tradeoff in memory. (I don't think that matters in this case so don't consider this line here)
There was a problem hiding this comment.
Cool. You took it even further than I was looking for with the ternary operators but it definitely has the impact I was hoping for. Clearer read and easier understanding of the logic that matters. In this case it is property setting and not business logic, and this change better represents that (imho)
| hasCustomWidth: false | ||
| }; | ||
|
|
||
| const gist = message?.properties?.gist; |
When the
exitClickproperty is set to true, we add a dismiss listener to modal messages.Part of: INAPP-12673