Skip to content

Address action handling within In-app Web SDK #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Address action handling within In-app Web SDK #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ef68e0
Removed error reporting when action doesn't require extra SDK handling.
Feb 11, 2025
cc03c8a
logBroadcastDismissedLocally is now called is message is dismissed pr…
Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/gist.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import EventEmitter from "./utilities/event-emitter";
import { log } from "./utilities/log";
import { startQueueListener, checkMessageQueue } from "./managers/queue-manager";
import { setUserToken, clearUserToken, useGuestSession } from "./managers/user-manager";
import { showMessage, embedMessage, hideMessage, removePersistentMessage, fetchMessageByInstanceId } from "./managers/message-manager";
import { showMessage, embedMessage, hideMessage, removePersistentMessage, fetchMessageByInstanceId, logBroadcastDismissedLocally } from "./managers/message-manager";
import { setUserLocale } from "./managers/locale-manager";
import { setupPreview } from "./utilities/preview-mode";

Expand Down Expand Up @@ -70,6 +70,7 @@ export default class {
var message = fetchMessageByInstanceId(instanceId);
await hideMessage(message);
await removePersistentMessage(message);
await logBroadcastDismissedLocally(message);
await checkMessageQueue();
}

Expand Down
6 changes: 3 additions & 3 deletions src/managers/message-manager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,8 +251,8 @@ async function handleGistEvents(e) {
break;
}
}
} catch (error) {
log(`Error processing action: ${error}`);
} catch {
// If the action is not a URL, we don't need to do anything.
}

break;
Expand Down Expand Up @@ -303,7 +303,7 @@ async function logUserMessageViewLocally(message) {
}
}

async function logBroadcastDismissedLocally(message) {
export async function logBroadcastDismissedLocally(message) {
if (isMessageBroadcast(message)) {
log(`Logging broadcast dismissed locally for: ${message.queueId}`);
await markBroadcastAsDismissed(message.queueId);
Expand Down