New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added proguard rules for R8 strict mode #116

Merged

Shahroz16 merged 2 commits into main from shahroz/flutter-updates

Apr 8, 2024

Collaborator

Shahroz16 commented Apr 8, 2024

helps: MBL-229 : Proguard rules for Android

What it does:

Bumps the android SDK version
Applied changes from Deprecated imperative apply of Flutter's Gradle plugins


          added updates for versions

3d2bb26

Shahroz16 requested a review from a team

April 8, 2024 17:45

Shahroz16 commented

View reviewed changes

android/build.gradle

@@ @@ -2,14 +2,14 @@ group 'io.customer.customer_io' @@
               version '1.0-SNAPSHOT'
               buildscript {
-                  ext.kotlin_version = '1.6.10'
+                  ext.kotlin_version = '1.7.21'

Collaborator Author

Shahroz16 Apr 8, 2024

these are matching the android SDK versions

pubspec.yaml

    
            @@ -16,7 +16,7 @@ dependencies:
          
              dev_dependencies:

                flutter_test:

                  sdk: flutter

                flutter_lints: ^2.0.0

                flutter_lints: ^3.0.2

Collaborator Author

Shahroz16 Apr 8, 2024

this is a dev dependency

apps/amiapp_flutter/lib/src/screens/dashboard.dart

               import 'package:customer_io/customer_io.dart';
               import 'package:customer_io/customer_io_inapp.dart';
-              import 'package:firebase_core/firebase_core.dart';

Collaborator Author

Shahroz16 Apr 8, 2024

unused imports

mrehan27 approved these changes

View reviewed changes

Contributor

mrehan27 left a comment

LGTM 👍🏻

apps/amiapp_flutter/android/app/build.gradle

@@ @@ -78,7 +68,7 @@ flutter { @@
               }
               dependencies {
-                  implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"
+                  implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.7.21"

Contributor

mrehan27 Apr 8, 2024

I think we should avoid hardcoding versions, as they are error-prone and harder to track when updating,

Collaborator Author

Shahroz16 Apr 8, 2024

agreed, left it for gradle 8 changes to not complicate this one.


          lint fix

7f11887

Shahroz16 merged commit 9946fe7 into main

4 checks passed

Shahroz16 deleted the shahroz/flutter-updates branch

April 8, 2024 18:03

github-actions bot pushed a commit that referenced this pull request


          chore: prepare for 1.3.2

a0c1d2f

## [1.3.2](1.3.1...1.3.2) (2024-04-08)

### Bug Fixes

* added proguard rules for R8 strict mode ([#116](#116)) ([9946fe7](9946fe7))

github-actions bot pushed a commit to AristideVB/customerio-flutter that referenced this pull request


          chore: prepare for 1.0.0

acc5dad

## 1.0.0 (2024-10-12)

### Features

* added missing methods ([customerio#17](https://github.com/AristideVB/customerio-flutter/issues/17)) ([73f29e6](73f29e6))
* added SDK config  ([customerio#1](https://github.com/AristideVB/customerio-flutter/issues/1)) ([e8ed7dd](e8ed7dd))
* do not show modal message if screen changes and page rule mismatches ([customerio#131](https://github.com/AristideVB/customerio-flutter/issues/131)) ([a563055](a563055))
* in-app dismiss support ([customerio#51](https://github.com/AristideVB/customerio-flutter/issues/51)) ([c4d21f2](c4d21f2))
* in-app message persistence ([customerio#97](https://github.com/AristideVB/customerio-flutter/issues/97)) ([71d85cc](71d85cc))
* process push notifications received outside CIO SDK ([customerio#38](https://github.com/AristideVB/customerio-flutter/issues/38)) ([7b5cb7e](7b5cb7e))
* support for android gradle plugin 8 ([customerio#117](https://github.com/AristideVB/customerio-flutter/issues/117)) ([48b4e06](48b4e06))
* tracking and in-app added ([customerio#2](https://github.com/AristideVB/customerio-flutter/issues/2)) ([c23f2d9](c23f2d9))

### Bug Fixes

* add test coverage and refactored scripts ([customerio#34](https://github.com/AristideVB/customerio-flutter/issues/34)) ([f7f2387](f7f2387))
* added proguard rules for R8 strict mode ([customerio#116](https://github.com/AristideVB/customerio-flutter/issues/116)) ([9946fe7](9946fe7))
* autoupdate to latest major version of iOS SDK ([customerio#40](https://github.com/AristideVB/customerio-flutter/issues/40)) ([974a342](974a342))
* formatting issues ([d67fa7e](d67fa7e))
* hardcode android native SDK version ([customerio#61](https://github.com/AristideVB/customerio-flutter/issues/61)) ([587f559](587f559))
* improve android push click behavior ([customerio#89](https://github.com/AristideVB/customerio-flutter/issues/89)) ([62b9e61](62b9e61))
* improve in-app logs ([customerio#139](https://github.com/AristideVB/customerio-flutter/issues/139)) ([b10cc75](b10cc75))
* in-app concurrency issue android ([customerio#73](https://github.com/AristideVB/customerio-flutter/issues/73)) ([93332a4](93332a4))
* in-app crash for no browser ([customerio#94](https://github.com/AristideVB/customerio-flutter/issues/94)) ([8b859ed](8b859ed))
* in-app messages not displaying for release builds on Android ([customerio#65](https://github.com/AristideVB/customerio-flutter/issues/65)) ([1d742c2](1d742c2))
* in-app remove gist org id ([customerio#19](https://github.com/AristideVB/customerio-flutter/issues/19)) ([ce4cc9e](ce4cc9e))
* iOS crash on forced unwrapping  ([customerio#59](https://github.com/AristideVB/customerio-flutter/issues/59)) ([f514174](f514174))
* missing methods and extra dependency ([2c5deca](2c5deca))
* missing opened metric on android 12 and above ([customerio#43](https://github.com/AristideVB/customerio-flutter/issues/43)) ([1a61e0e](1a61e0e))
* obj-c bindings issue ([0dbe4ef](0dbe4ef))
* plugin version in user-agent ([a10e482](a10e482))
* release script typo ([2a8b7ae](2a8b7ae))
* send native to flutter messages on main thread ([customerio#134](https://github.com/AristideVB/customerio-flutter/issues/134)) ([bc8704b](bc8704b))
* stack-overflow caused by BQ recursion ([customerio#90](https://github.com/AristideVB/customerio-flutter/issues/90)) ([ebc7511](ebc7511))
* typo fixed ([customerio#9](https://github.com/AristideVB/customerio-flutter/issues/9)) ([a5107df](a5107df)), closes [customerio#7](https://github.com/AristideVB/customerio-flutter/issues/7) [customerio#8](https://github.com/AristideVB/customerio-flutter/issues/8)
* updated android dependency to auto update ([customerio#24](https://github.com/AristideVB/customerio-flutter/issues/24)) ([040cef2](040cef2))
* updated icon and typo ([57c6eef](57c6eef))
* updated module name from common to CioInternalCommon ([customerio#55](https://github.com/AristideVB/customerio-flutter/issues/55)) ([d81f8df](d81f8df))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet