Fix value scope nesting in Typescript #1929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokey
commented
Oct 4, 2023
There was a problem hiding this comment.
When you say "next value" from the start of the statement, if there's a nested value, you'll get it; if not, you'll end up with the value from the next line. It's a bit opaque, but this test would fail on main
AndreasArvidsson
approved these changes
Oct 5, 2023
fidgetingbits
pushed a commit
to fidgetingbits/cursorless
that referenced
this pull request
Nov 3, 2023
We only want nested value scopes if there is more than one declarator in a statement. Before: <img width="186" alt="image" src="https://github.com/cursorless-dev/cursorless/assets/755842/0aaf4491-2c68-4be2-849d-ff5c72ac968a"> After: <img width="185" alt="image" src="https://github.com/cursorless-dev/cursorless/assets/755842/3058a007-73b0-48cc-81dd-6f5b126fa07a"> Unfortunately we have no good way to test this change until we have cursorless-dev#1524 **Edit**: I found a way to test it, but it's a bit hacky. ## Checklist - [ ] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [ ] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [ ] I have not broken the cheatsheet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only want nested value scopes if there is more than one declarator in a statement.
Before:
After:
Unfortunately we have no good way to test this change until we have #1524
Edit: I found a way to test it, but it's a bit hacky.
Checklist