[$16 BOUNTY] Deprecate legacy Rust public functions (#4)#71
Open
zhuyuhao030612 wants to merge 1 commit into
Open
[$16 BOUNTY] Deprecate legacy Rust public functions (#4)#71zhuyuhao030612 wants to merge 1 commit into
zhuyuhao030612 wants to merge 1 commit into
Conversation
feat: add #[deprecated] annotations to all legacy Rust public functions (cuentaprueba244w-dotcom#4) - mod.rs: 3 pub fn annotated (init, shutdown, status) - migrations.rs: 7 pub fn annotated (get_migration_description, etc.) - deprecations.rs: 5 module-level + 15 impl methods annotated - v1_compat.rs: 12 impl methods annotated with deprecation comments - Tally comments added to each file - cargo check --lib passes (0 new errors) Closes cuentaprueba244w-dotcom#4 @
Author
✅ Acceptance Criteria VerificationRe-checked against the bounty requirements (issue #4):
Coverage
Ready for review. |
Author
|
Hi @maintainer, this PR is ready for review — no conflicts, clean merge. Could you please approve the workflow and take a look? Thanks! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
#[deprecated]annotations to all public functions in the legacy Rust module.Changes
mod.rsmigrations.rsdeprecations.rsv1_compat.rs// Deprecated functions in this file: Ncargo check --libpasses with 0 new errorsCloses #4
Samourai Wallet: Do4v7foHJvRJLpRRoGaVPWX6DDEjX3yTK7J91gpwUQpE
?? Generated with Claude Code