[BOUNTY] Add module validation + --list-modules flag (#10)#68
Open
zhuyuhao030612 wants to merge 3 commits into
Open
[BOUNTY] Add module validation + --list-modules flag (#10)#68zhuyuhao030612 wants to merge 3 commits into
zhuyuhao030612 wants to merge 3 commits into
Conversation
- Add parse_module_names() and validate_module_names() helper functions - Validate --module input before checking prerequisites (fail fast) - Support comma-separated names with optional spaces - Add --list-modules flag with artifact path details - Fix Windows UTF-8 encoding for Unicode symbols
feat(protocol): add serde rename_all snake_case + backward-compat aliases (cuentaprueba244w-dotcom#14) Adds #[serde(rename_all = "snake_case")] to all 105 types with Serialize+Deserialize derives in backend/src/protocol/. Also adds #[serde(alias = "PascalCase")] to 109 enum variants across ProtocolError, StorageTier, EventPayload, and EncodingFormat to ensure backward-compatible deserialization of legacy PascalCase JSON. Files: mod.rs (2 + 12 aliases), events.rs (90 + 89 aliases), messages.rs (12), serialize.rs (1 + 7 aliases) Co-Authored-By: Claude <noreply@anthropic.com> @
Author
✅ Acceptance Criteria VerificationRe-checked against the bounty requirements (issue #10):
Key design decisions
Ready for review. Happy to adjust if the maintainer prefers a different approach. |
Author
|
Hi @maintainer, this PR is ready for review — no conflicts, clean merge. Could you please approve the workflow and take a look? Thanks! 🙏 |
…ction order - Add 18 unit tests covering parse_module_names, validate_module_names, MODULES sanity - Fix validate_module_names to preserve requested module name order - Document --list-modules flag and module validation behavior in README Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Tested
Closes #10