cmd/cueckoo: add short commit hash to "Closes" for importpr #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we import a PR from GitHub we immediately lose track of the original commit sha because of necessary commit message rewriting. Currently this means we have no easy way of anyone tracking exactly what was imported. Per a suggestion from @mvdan, we can simply add this to the "Closes" message for now, and later consider writing a message back to the PR from which we are importing with more information. For #33.
myitcv
force-pushed
the
add_abbrev_commit_to_closes_message
branch
from
27c1ae5 to
43a7b09
Compare
mvdan
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see commit message)
For #33.