Skip to content

Conversation

@davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Sep 14, 2025

🤔 What's changed?

Replace usage of crypto.randomUUID here with the uuid library so it works in insecure contexts like plain HTTP which is common with self-hosted HTML reports.

⚡️ What's your motivation?

Fixes #400

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@netlify
Copy link

netlify bot commented Sep 14, 2025

Deploy Preview for cucumber-react-preview ready!

Name Link
🔨 Latest commit 5e54f69
🔍 Latest deploy log https://app.netlify.com/projects/cucumber-react-preview/deploys/68c6a593179f5f000836c13a
😎 Deploy Preview https://deploy-preview-402--cucumber-react-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Sep 14, 2025

Deploy Preview for cucumber-react-preview ready!

Name Link
🔨 Latest commit fe7a0c1
🔍 Latest deploy log https://app.netlify.com/projects/cucumber-react-preview/deploys/68c6a5c3588914000882fce0
😎 Deploy Preview https://deploy-preview-402--cucumber-react-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@davidjgoss davidjgoss marked this pull request as ready for review September 14, 2025 11:29
@davidjgoss davidjgoss merged commit 495987d into main Sep 14, 2025
6 checks passed
@davidjgoss davidjgoss deleted the fix/uuid-use-library branch September 14, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reports do not work over http due to use of crypto API

1 participant