Skip to content

Add location to pickle #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add location to pickle #308

wants to merge 1 commit into from

Conversation

mpkorstanje
Copy link
Contributor

πŸ€” What's changed?

⚑️ What's your motivation?

🏷️ What kind of change is this?

  • πŸ“– Documentation (improvements without changing code)
  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)
  • πŸ› Bug fix (non-breaking change which fixes a defect)
  • ⚑ New feature (non-breaking change which adds new behaviour)
  • πŸ’₯ Breaking change (incompatible changes to the API)

♻️ Anything particular you want feedback on?

πŸ“‹ Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@clrudolphi
Copy link
Contributor

In all other objects that contain a Location, by convention, the Location is the first property mentioned and thus the first parameter in the generated constructors. This proposed change has the Location as the last property mentioned; and thus the last parameter in the parameter list. This inconsistency is a bit jarring. Can we move it up to the top of the property list?

@clrudolphi
Copy link
Contributor

For Examples(Scenario Outlines), what is the proper Location of the pickle resulting from the table?

@mpkorstanje
Copy link
Contributor Author

mpkorstanje commented Jul 21, 2025

In all other objects that contain a Location, by convention, the Location is the first property mentioned and thus the first parameter in the generated constructors. This proposed change has the Location as the last property mentioned; and thus the last parameter in the parameter list. This inconsistency is a bit jarring. Can we move it up to the top of the property list?

Sure!

For Examples(Scenario Outlines), what is the proper Location of the pickle resulting from the table?

The pickle location is the same as the location of the example row used to create the pickle. The line of the scenario outline would not uniquely identify the pickle as it could refer to any of the examples in that scenario outline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants