fix: Validate the handler function param types when registering steps. #701
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
It checks the step handler params while registering the steps.
⚡️ What's your motivation?
There is a FIXME tag in test_context.go file and I think I can fix it.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
I think we should have different error message when step registering/run because the
context.Contextparam is in a wrong place. So probably it would be a good idea to fix it in another pr, wondering whether I should fix it in a new pr.for example:
when there is a handler like this:
Maybe we can panic with
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.