Add a fix for mangling longer CHANGELOGs #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reads the whole file in and closes it before attempting to open the file for writing, thereby avoiding the situation where we start writing to the file (and truncating it) before we've read it in, or overwrite the existing file and leave old bytes at the end. There are no tests for this because the code in root.go is not (yet!) tested. I've tested it manually. Co-authored-by: Carl Menezes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
This reads the whole file in and closes it before attempting to open the file for writing, thereby avoiding the situation where we start writing to the file (and truncating it) before we've read it in, or overwrite the existing file and leave old bytes at the end.
⚡️ What's your motivation?
Fix #9
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
There are no tests for this because the code in
root.gois not (yet!) tested. I've tested it manually.📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.