This repository has been archived by the owner on Mar 27, 2019. It is now read-only.
Update _animate.js #1256
Open
Update _animate.js #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm seeing a bug in Safari 12.0.2/OSX 10.13.6 in which this condition is not met, and therefore scrollEnd never gets fired. It only happens when the user gets to the end of the scroll pane, goes up a couple pages, then goes back to the end. If I remove the if statement, scrollEnd is always fired and the issue is resolved. Is there a hidden negative to doing that which I've not yet seen?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm seeing a bug in Safari 12.0.2/OSX 10.13.6 in which this condition is not met, and therefore scrollEnd never gets fired. It only happens when the user gets to the end of the scroll pane, goes up a couple pages, then goes back to the end. If I remove the if statement, scrollEnd is always fired and the issue is resolved. Is there a hidden negative to doing that which I've not yet seen?