Skip to content

load insightface from extra_model_path#38

Open
xingren23 wants to merge 3 commits intocubiq:mainfrom
xingren23:main
Open

load insightface from extra_model_path#38
xingren23 wants to merge 3 commits intocubiq:mainfrom
xingren23:main

Conversation

@xingren23
Copy link

@xingren23 xingren23 commented Feb 21, 2024

https://github.com/cubiq/ComfyUI_InstantID/issues/37

and Import InsightFace as needed

@cubiq
Copy link
Owner

cubiq commented Mar 8, 2024

insightface is always needed for instantid so it can be loaded at startup

@xingren23
Copy link
Author

Sure, that makes sense;
In my scenario, ComfyUI is utilized in a serverless fashion, where the ComfyUI container is launched for the duration of the execution and terminated post-execution. Since not every workflow necessitates the use of InstantIDFaceAnalysis, I am looking into ways to optimize the startup time.

@alexalok
Copy link

alexalok commented May 7, 2024

would love to see it merged!

@TrevorSquillario
Copy link

Would like to see this added as well. extra_model_paths should be supported by all custom nodes that load external models. I'm running in a docker environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants