Fix dtype inference and session cookie handling #1237

Cubewise-Ronan · 2025-04-09T03:11:01Z

Set default dtype to str in pd.read_csv to avoid misinterpreting values like '2025' as floats.
Fixed issue with multiple 'TM1SessionId' cookies causing CookieConflictError during session start.

File "C:\Dev\share_service\venv\lib\site-packages\TM1py\Services\RestService.py", line 789, in _start_session
    session_id = self._s.cookies.pop('TM1SessionId', None)
  File "C:\Program Files\Python310\lib\_collections_abc.py", line 954, in pop
    value = self[key]
  File "C:\Dev\share_service\venv\lib\site-packages\requests\cookies.py", line 334, in __getitem__
    return self._find_no_duplicates(name)
  File "C:\Dev\share_service\venv\lib\site-packages\requests\cookies.py", line 405, in _find_no_duplicates
    raise CookieConflictError(
requests.cookies.CookieConflictError: There are multiple cookies with name, 'TM1SessionId'

…pe inference

MariusWirtz · 2025-04-09T09:23:02Z

TM1py/Utils/Utils.py

@@ -545,7 +545,7 @@ def build_dataframe_from_csv(raw_csv, sep='~', shaped: bool = False,

    # make sure all element names are strings and values column is derived from data
    if 'dtype' not in kwargs:
-        kwargs['dtype'] = {'Value': None, **{col: str for col in range(999)}}
+        kwargs['dtype'] = {'Value': str, **{col: str for col in range(999)}}


We don't want the value column to be str in all cases, do we?

If we set it to None instead, it will be derived depending on the data at hand

Actually, that was the issue I was running into — setting 'Value': None causes pandas to infer the dtype, and in some cases like "2025" (which is an attribute value for an element and should be a string), it gets coerced to 2025.0 if other rows are missing values or inconsistent.

I understand. But we can't enforce str as the column type for the value column. Most retrieved cube data will be numeric!

In the edge cases where you load data from attribute cubes it would be easier to pass dtype=str to the execute_mdx_dataframe function.

MariusWirtz · 2025-04-09T09:24:49Z

TM1py/Services/RestService.py

+            for cookie in self._s.cookies:
+                if cookie.name == 'TM1SessionId':
+                    session_id = cookie.value
+                    # break  # Use the first match


Maybe this is an obsolete comment or did you want to break after the first match?

Cubewise-Ronan added 2 commits April 9, 2025 11:05

fix: set default dtype to str in pd.read_csv to prevent unintended ty…

fafdb3f

…pe inference

fix: multiple cookies with name, 'TM1SessionId'

cac555d

MariusWirtz reviewed Apr 9, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix dtype inference and session cookie handling #1237

Fix dtype inference and session cookie handling #1237

Cubewise-Ronan commented Apr 9, 2025

MariusWirtz Apr 9, 2025

Cubewise-Ronan Apr 9, 2025

MariusWirtz Apr 9, 2025

MariusWirtz Apr 9, 2025

Fix dtype inference and session cookie handling #1237

Are you sure you want to change the base?

Fix dtype inference and session cookie handling #1237

Conversation

Cubewise-Ronan commented Apr 9, 2025

MariusWirtz Apr 9, 2025

Choose a reason for hiding this comment

Cubewise-Ronan Apr 9, 2025

Choose a reason for hiding this comment

MariusWirtz Apr 9, 2025

Choose a reason for hiding this comment

MariusWirtz Apr 9, 2025

Choose a reason for hiding this comment