Skip to content

Conversation

@KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Sep 12, 2025

This PR supersedes the original one by @paco-valdez.

Updated with a simpler one-time drillMembers evaluation.

Fixes #6778.
Closes #9959.

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet

@KSDaemon KSDaemon marked this pull request as ready for review September 12, 2025 14:52
@KSDaemon KSDaemon requested a review from a team as a code owner September 12, 2025 14:52
@KSDaemon KSDaemon force-pushed the fix/inherit-drill-members branch from 16db64a to ca9d3b7 Compare September 22, 2025 07:23
@KSDaemon KSDaemon force-pushed the fix/inherit-drill-members branch from 4e37f9d to 25fd1d2 Compare October 15, 2025 18:21
@github-actions github-actions bot added the javascript Pull requests that update Javascript code label Oct 15, 2025
@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 37.50000% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.79%. Comparing base (9a51a5a) to head (e5657b0).

Files with missing lines Patch % Lines
...cubejs-schema-compiler/src/compiler/CubeSymbols.ts 37.50% 12 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9966      +/-   ##
==========================================
- Coverage   48.82%   48.79%   -0.04%     
==========================================
  Files         196      196              
  Lines       15824    15840      +16     
  Branches     3101     3106       +5     
==========================================
+ Hits         7726     7729       +3     
- Misses       7706     7716      +10     
- Partials      392      395       +3     
Flag Coverage Δ
cube-backend 48.79% <37.50%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon force-pushed the fix/inherit-drill-members branch from 25fd1d2 to e5657b0 Compare October 24, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Measures in views don't inherit drill_members

2 participants