feat(cubesql): Support trivial casts in member pushdown #9480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcheshkov
force-pushed
the
member-pushdown-cast
branch
from
28db177 to
a7c10cd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9480 +/- ##
==========================================
- Coverage 83.87% 80.31% -3.56%
==========================================
Files 230 395 +165
Lines 83825 97349 +13524
Branches 0 2278 +2278
==========================================
+ Hits 70305 78185 +7880
- Misses 13520 18856 +5336
- Partials 0 308 +308
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MazterQyou
approved these changes
Apr 24, 2025
…bers All matching happening with CubeScanMembers on top of actual members node, and this rule does not expect that member_name_to_expr part of analysis can extract members from CubeScanMembers(AllMembers), so there's no reason to keep this rule
…_old_member argument
mcheshkov
force-pushed
the
member-pushdown-cast
branch
from
a7c10cd to
1312aba
Compare
marianore-muttdata
pushed a commit
to MuttData/cube
that referenced
this pull request
Jun 17, 2025
This should allow pushing down expressions like `CAST(dimension AS TEXT) AS alias` into `CubeScan` as regular dimensions. And that, in turn, should allow `__cubeJoinField` joins to see more `CubeScan`s Supporting changes: Remove unused rule for member pushdown from `AllMembers` All matching happening with `CubeScanMembers` on top of actual members node, and this rule does not expect that `member_name_to_expr` part of analysis can extract members from `CubeScanMembers(AllMembers)`, so there's no reason to keep this rule Add explicit type in `var!` macro, to avoid type confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made (if issue reference is not provided)
This should allow pushing down expressions like
CAST(dimension AS TEXT) AS aliasintoCubeScanas regular dimensions.This should allow
__cubeJoinFieldjoins to see moreCubeScansSupporting changes:
Remove unused rule for member pushdown from
AllMembersAll matching happening with
CubeScanMemberson top of actual members node, and this rule does not expect thatmember_name_to_exprpart of analysis can extract members fromCubeScanMembers(AllMembers), so there's no reason to keep this ruleAdd explicit type in
var!macro, to avoid type confusion.