-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(clickhouse-driver): allow to enable compression #9341
base: master
Are you sure you want to change the base?
feat(clickhouse-driver): allow to enable compression #9341
Conversation
Thanks for the comments, I also updated the |
Before we merge this— @Graphmaxer Did you confirm that enabling the compression actually improves the performance for large result sets? |
Also, if this is a non-breaking change (except for the nuance with read-only connections), should we consider enabling the compression by default in the next minor version of Cube? |
I did some testing documented in my issue #9340, I got positive impact in my use case. According to the Clickhouse documentation, this can have negative impacts depending on the queries.
https://clickhouse.com/docs/integrations/javascript#tips-for-performance-optimizations |
Also facing the same issue when using PowerBI... Queries time out, but when replaying them in Clickhouse directly, they are almost instantaneous. |
Check List
Issue Reference this PR resolves
Description of Changes Made
Allow to enable compression via env variable for clickhouse driver