Skip to content

Conversation

roxanan1996
Copy link

@roxanan1996 roxanan1996 commented Oct 9, 2025

Commit: 3d30048 ("kernel: i2c/designware: Fix an initialization issue") was cherry-picked from linux-mainline. It applied cleanly.

BUILD

> grep -E -B 5 -A 5 '\[TIMER\]|^Starting Build' ~/ciq/vms/fips-legacy-8-compliant_4.18.0-425.13.1/kernel-build-after.log
/home/rnicolescu/ciq/vms/fips-legacy-8-compliant_4.18.0-425.13.1/kernel-src-tree-fix
Skipping make mrproper
[TIMER]{MRPROPER}: 0s
x86_64 architecture detected, copying config
'configs/kernel-x86_64.config' -> '.config'
Setting Local Version for build
CONFIG_LOCALVERSION="-rnicolescu_fips-legacy-8-compliant_4.18.0-425.13.1-bb"
Making olddefconfig
scripts/kconfig/conf  --olddefconfig Kconfig
#
# configuration written to .config
#
Starting Build
scripts/kconfig/conf  --syncconfig Kconfig
  DESCEND objtool
  DESCEND bpf/resolve_btfids
  CALL    scripts/checksyscalls.sh
  CHK     include/generated/compile.h
--
  LD [M]  sound/usb/usx2y/snd-usb-usx2y.ko
  LD [M]  sound/virtio/virtio_snd.ko
  LD [M]  sound/x86/snd-hdmi-lpe-audio.ko
  LD [M]  sound/xen/snd_xen_front.ko
  LD [M]  virt/lib/irqbypass.ko
[TIMER]{BUILD}: 227s
Making Modules
  INSTALL arch/x86/crypto/camellia-aesni-avx-x86_64.ko
  INSTALL arch/x86/crypto/blowfish-x86_64.ko
  INSTALL arch/x86/crypto/camellia-aesni-avx2.ko
  INSTALL arch/x86/crypto/camellia-x86_64.ko
--
  INSTALL sound/virtio/virtio_snd.ko
  INSTALL sound/x86/snd-hdmi-lpe-audio.ko
  INSTALL sound/xen/snd_xen_front.ko
  INSTALL virt/lib/irqbypass.ko
  DEPMOD  4.18.0-rnicolescu_fips-legacy-8-compliant_4.18.0-425.13.1-bb+
[TIMER]{MODULES}: 10s
Making Install
sh ./arch/x86/boot/install.sh 4.18.0-rnicolescu_fips-legacy-8-compliant_4.18.0-425.13.1-bb+ arch/x86/boot/bzImage \
	System.map "/boot"
[TIMER]{INSTALL}: 15s
Checking kABI
kABI check passed
Setting Default Kernel to /boot/vmlinuz-4.18.0-rnicolescu_fips-legacy-8-compliant_4.18.0-425.13.1-bb+ and Index to 0
The default is /boot/loader/entries/e17869c0a02342769382e3df7e081f47-4.18.0-rnicolescu_fips-legacy-8-compliant_4.18.0-425.13.1-bb+.conf with index 0 and kernel /boot/vmlinuz-4.18.0-rnicolescu_fips-legacy-8-compliant_4.18.0-425.13.1-bb+
The default is /boot/loader/entries/e17869c0a02342769382e3df7e081f47-4.18.0-rnicolescu_fips-legacy-8-compliant_4.18.0-425.13.1-bb+.conf with index 0 and kernel /boot/vmlinuz-4.18.0-rnicolescu_fips-legacy-8-compliant_4.18.0-425.13.1-bb+
Generating grub configuration file ...
done
Hopefully Grub2.0 took everything ... rebooting after time metrices
[TIMER]{MRPROPER}: 0s
[TIMER]{BUILD}: 227s
[TIMER]{MODULES}: 10s
[TIMER]{INSTALL}: 15s
[TIMER]{TOTAL} 254s
Rebooting in 10 seconds

kernel-build-before.log
kernel-build-after.log

Kselftests

> ~/ciq/vms/fips-legacy-8-compliant_4.18.0-425.13.1/kernel-tools/kselftest-diff.sh ~/ciq/vms/fips-legacy-8-compliant_4.18.0-425.13.1
/home/rnicolescu/ciq/vms/fips-legacy-8-compliant_4.18.0-425.13.1/kselftest-before.log
219
/home/rnicolescu/ciq/vms/fips-legacy-8-compliant_4.18.0-425.13.1/kselftest-after.log
220
Before: /home/rnicolescu/ciq/vms/fips-legacy-8-compliant_4.18.0-425.13.1/kselftest-before.log
After: /home/rnicolescu/ciq/vms/fips-legacy-8-compliant_4.18.0-425.13.1/kselftest-after.log
Diff:
+ok 51 selftests: kvm: max_guest_memory_test

kselftest-before.log
kselftest-after.log

Check_kernel_commits including interdiff

> check_kernel_commits.py --repo ~/ciq/vms/fips-legacy-8-compliant_4.18.0-425.13.1/kernel-src-tree-fix --pr_branch {rnicolescu}_fips-legacy-8-compliant_4.18.0-425.13.1 --base_branch fips-legacy-8-compliant/4.18.0-425.13.1
Comparing commits 3d30048958e0d43425f6d4e76565e6249fa71050 and bba4d0ef9de7682f5b13ef437cc3d8dcbaf6c59e...
interdiff result:
No diff between 3d30048958e0d43425f6d4e76565e6249fa71050 and bba4d0ef9de7682f5b13ef437cc3d8dcbaf6c59e
All referenced commits exist upstream and have no Fixes: tags.

jira VULN-79508
cve CVE-2025-38380
commit-author Michael J. Ruhl <[email protected]>
commit 3d30048

The i2c_dw_xfer_init() function requires msgs and msg_write_idx from the
dev context to be initialized.

amd_i2c_dw_xfer_quirk() inits msgs and msgs_num, but not msg_write_idx.

This could allow an out of bounds access (of msgs).

Initialize msg_write_idx before calling i2c_dw_xfer_init().

	Reviewed-by: Andy Shevchenko <[email protected]>
Fixes: 17631e8 ("i2c: designware: Add driver support for AMD NAVI GPU")
	Cc: <[email protected]> # v5.13+
	Signed-off-by: Michael J. Ruhl <[email protected]>
	Signed-off-by: Andi Shyti <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
(cherry picked from commit 3d30048)
	Signed-off-by: Roxana Nicolescu <[email protected]>
@roxanan1996 roxanan1996 requested a review from a team October 9, 2025 15:33
Copy link
Collaborator

@bmastbergen bmastbergen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥌

@roxanan1996 roxanan1996 self-assigned this Oct 10, 2025
@bmastbergen bmastbergen requested a review from a team October 10, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants