A couple of changes to support Fedora #1155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the stuff I found I needed to make this script work on Fedora. We also install the branch of sslpsk that backs this PR: drbild/sslpsk#28 because current upstream sslpsk does not work on Python 3.12+, and so does not work on current stable Fedora. Signed-off-by: Adam Williamson <[email protected]>
On systems that use systemd-resolved (e.g. Fedora/RHEL installs out of the box, usually), it listens on port 53, so it blocks this tool. This should handle disabling and masking it at the start of `start_flash.sh`, then unmasking and restarting it at the end. Signed-off-by: Adam Williamson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a Fedora block to
install_prereq.sh, and enhancesstart_flash.shto handle disabling systemd-resolved at the start and re-enabling it at the end, if it's being used (it listens on port 53, which this tool needs to take over).In the Fedora block we use a PR branch of sslpsk which makes it work with Python 3.12 and later, because current Fedoras are on 3.12 or 3.13. Other distros may also need this change now or soon. See drbild/sslpsk#28 .
This should make it work more or less out of the box on Fedora, following the instructions. I was able to convert a couple of old smart plugs I found lying around after doing the equivalent of these changes, so thanks for the tool!