-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for AOSP su (without -c argument) #79
Open
vgavro
wants to merge
15
commits into
cswl:v8
Choose a base branch
from
vgavro:v8
base: v8
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
related to #72 |
…t if prepend is not set); fixed bug with not adding android sys path in tsu and ignoring both -p/-a options (it was depended on LD_LIBRARY_PATH for some reason... - looks like misprint while adding some LD_LIBRARY_PATH logic); (possibly both related to pull#63); creating TMPDIR (merged pull#75); aosp su: fixed reseting PATH inside su
Besides adding support for aosp su binaries - there are plenty fixes I found which I had to fix, sorry for this LARGE pull request... I hope it could be merged to upstream anyway...
TODO/NOTES:
My proposition - to release next major version (9.0) and rename |
…rgument); explicitly pass environment variables (some su does not preserve environments, even if there is option for it)
…nyone wanted to do that?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AOSP "su" version never had "-c" flag option, like I see from sources.
I tried not to break compatibility with previous tsu version, while trying to determine AOSP su by
--help
, or (in case for older android versions) you may explicitly set it likeSU_AOSP=1 sudo id