Skip to content

cmake: fix integration with Ninja #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2025
Merged

cmake: fix integration with Ninja #227

merged 2 commits into from
Apr 24, 2025

Conversation

lzaoral
Copy link
Member

@lzaoral lzaoral commented Apr 23, 2025

No description provided.

lzaoral added 2 commits April 23, 2025 15:55
Fixes the following error:
```
$ ninja -C build
ninja: Entering directory `build'
ninja: warning: phony target 'src/csfilter-kfp.1' names itself as an input; ignoring [-w phonycycle=warn]
ninja: error: build.ninja:471: multiple rules generate src/csfilter-kfp.1
```
Otherwise, the output was suppressed when Ninja was used.
@lzaoral lzaoral requested a review from kdudka April 23, 2025 13:57
@lzaoral lzaoral self-assigned this Apr 23, 2025
Copy link
Member

@kdudka kdudka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@lzaoral lzaoral merged commit 64aa715 into csutils:main Apr 24, 2025
36 checks passed
@lzaoral lzaoral deleted the ninja-docs branch April 24, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants