cstrans-df-run: introduce the --shell-form option #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzaoral
reviewed
Feb 5, 2025
|
|
||
| // store the list to "*pDst" and return "true" if the list is not empty | ||
| TDst &dst = *pDst; | ||
| dst = vm[key].template as<TDst>(); |
kdudka
force-pushed
the
shell-form
branch
3 times, most recently
from
5c22729 to
c59f94d
Compare
... so that we do not need to bump the version manually in the YAML file Fixes: commit 56ac540 Related: csutils#214
... to eliminate duplicated code. No change in behavior intended with this commit.
... to make the code easier to extend. No change in behavior intended with this commit.
... so that it can easily access TransformerProps. No change in behavior intended with this commit.
... to write transformed RUN lines using the shell form (rather than exec form, which is the default format). Related: https://issues.redhat.com/browse/KFLUXBUGS-1943 Related: https://issues.redhat.com/browse/OSH-809
No change in behavior intended with this commit.
|
/packit rebuild-failed |
kdudka
added a commit
to kdudka/csdiff
that referenced
this pull request
Feb 7, 2025
... so that tests with/without the `--shell-form` option get assigned distinct test names rather than effectively overwriting each other. This one-line change enables additional 11 tests. Fixes: commit b05206d Related: csutils#217 Closes: csutils#219
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to write transformed RUN lines using the shell form (rather than exec form, which is the default format).
Related: https://issues.redhat.com/browse/KFLUXBUGS-1943
Related: https://issues.redhat.com/browse/OSH-809