Skip to content

Incident sidebar styles#296

Open
aileenr19 wants to merge 54 commits intomainfrom
aileen/incident-sidebar-styles
Open

Incident sidebar styles#296
aileenr19 wants to merge 54 commits intomainfrom
aileen/incident-sidebar-styles

Conversation

@aileenr19
Copy link
Copy Markdown
Collaborator

We need to update the incident sidebar to match the Figma board.

Changes:

  • Changed the styling for the sidebar
  • Changed the styling for the modal
  • Removed a redundant sidebar file

Closes #276

mfandohan05 and others added 30 commits February 8, 2026 23:11
@aileenr19 aileenr19 requested a review from naasanov April 7, 2026 21:20
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

Test Results Summary

559 tests  ±0   559 ✅ ±0   37s ⏱️ -3s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 91ed8f6. ± Comparison against base commit 1a6ef42.

♻️ This comment has been updated with latest results.

Copy link
Copy Markdown
Collaborator

@naasanov naasanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference ID and description should be in italics when they are empty values

Copy link
Copy Markdown
Collaborator

@naasanov naasanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When opening the modal, I get the following two errors:

In HTML, <h1> cannot be a child of <h2>.
This will cause a hydration error.
<h2> cannot contain a nested <h1>.
See this log for the ancestor stack trace.

] as IncidentSeverity[]
).map((s) => (
<SelectItem key={s} value={s}>
{s.charAt(0).toUpperCase() + s.slice(1)}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The toUpperCase doesn't play well with underscores

Copy link
Copy Markdown
Collaborator

@naasanov naasanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also needs to be updated to main. Some time formatting utils were added. Even though its correct right now, it should use the utils for consistency

@aileenr19 aileenr19 requested a review from naasanov April 9, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incident Sidebar Styles

3 participants