Open
Conversation
Added backend guard (403) and frontend UI restriction so admins cannot delete their own account from the dashboard. Includes a new router test covering the self-deletion case. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
naasanov
requested changes
Apr 8, 2026
Collaborator
naasanov
left a comment
naasanov
left a comment
There was a problem hiding this comment.
I still see the delete button. Does it work on your end?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent admins from deleting their own account through the dashboard. Without this guard, an admin could accidentally lock themselves out, which could destabilize access to the system.
Changes:
CannotDeleteOwnAccountException(403) toaccount_service.pyDELETE /api/accounts/{account_id}router to capture the current admin's identity and raise 403 if they attempt to delete themselvestest_delete_own_accountrouter test; updatedtest_delete_account_not_foundto use a non-conflicting IDisDeleteDisabledprop toTableTemplateto conditionally hide the Delete menu item per rowAccountTablefor the currently logged-in admin's own rowCloses #249