Skip to content

Intergrated Filter/Sort- Matthew#279

Merged
naasanov merged 4 commits intomainfrom
Integrated-Filter/Sort
Apr 7, 2026
Merged

Intergrated Filter/Sort- Matthew#279
naasanov merged 4 commits intomainfrom
Integrated-Filter/Sort

Conversation

@MatthewBarghout
Copy link
Copy Markdown
Collaborator

High level motivation for making the changes

Changes:

  • Route TanStack Table sorting, filtering, and pagination through backend API
    instead of client-side
    • Add shared query-params utility to map column IDs to backend field names and
      build URL params
    • Update TableTemplate with server mode (manualSorting/Filtering/Pagination,
      debounced filter callbacks, hidden global search)
    • Update all four admin table services and React Query hooks to accept server
      params with keepPreviousData
    • Add SERVER_COLUMN_MAP to each table component mapping columns to backend
      fields and filter operators
    • Fix police-party query to use new listParties signature

Closes #263

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2026

Test Results Summary

551 tests  ±0   551 ✅ ±0   41s ⏱️ +4s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 7ccd619. ± Comparison against base commit 36f8571.

♻️ This comment has been updated with latest results.

@naasanov naasanov self-requested a review April 1, 2026 16:30
Copy link
Copy Markdown
Collaborator

@naasanov naasanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work and I appreciate the adherance to layers and keeping stuff DRY.

However there are a lot of rough edges with some missing filters and uncomfortable UX. The most important thing is to just keep iterating until you feel like this is a feature you feel good using and you feel like you would use yourself as a user, and all cases are covered. If you are not expereincing some of the freezes and such on your end, let me know.

Copy link
Copy Markdown
Collaborator

@naasanov naasanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@naasanov naasanov merged commit 46dbc32 into main Apr 7, 2026
3 checks passed
@naasanov naasanov deleted the Integrated-Filter/Sort branch April 7, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrated Filter/Sort For Tables

2 participants