Conversation
naasanov
requested changes
Apr 1, 2026
Collaborator
naasanov
left a comment
There was a problem hiding this comment.
Great work and I appreciate the adherance to layers and keeping stuff DRY.
However there are a lot of rough edges with some missing filters and uncomfortable UX. The most important thing is to just keep iterating until you feel like this is a feature you feel good using and you feel like you would use yourself as a user, and all cases are covered. If you are not expereincing some of the freezes and such on your end, let me know.
frontend/src/app/staff/_components/shared/table/TableTemplate.tsx
Outdated
Show resolved
Hide resolved
frontend/src/app/staff/_components/shared/table/TableTemplate.tsx
Outdated
Show resolved
Hide resolved
…into Integrated-Filter/Sort
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High level motivation for making the changes
Changes:
instead of client-side
build URL params
debounced filter callbacks, hidden global search)
params with keepPreviousData
fields and filter operators
Closes #263