Skip to content

Frontend incidents table#268

Merged
naasanov merged 48 commits intomainfrom
aileen/frontend-incidents-table
Apr 7, 2026
Merged

Frontend incidents table#268
naasanov merged 48 commits intomainfrom
aileen/frontend-incidents-table

Conversation

@aileenr19
Copy link
Copy Markdown
Collaborator

With the new incident structure, the frontend needs to be updated to match. Additionally, staff need a table to track individual incidents with sorting, filtering, etc. functionality.

Changes:

  • New incident DTO models
  • Student view updated with new models
  • Incident info chip updates with new models
  • Incidents table created along with description sidebar

Closes #246.

mfandohan05 and others added 30 commits February 8, 2026 23:11
@aileenr19 aileenr19 requested a review from naasanov March 26, 2026 20:42
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 26, 2026

Test Results Summary

551 tests  ±0   551 ✅ ±0   38s ⏱️ -1s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 319b565. ± Comparison against base commit 46dbc32.

♻️ This comment has been updated with latest results.

Copy link
Copy Markdown
Collaborator

@naasanov naasanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to Cmd + Shift + F "complaint" in frontend/src and find several places where the frontend was not updated to the new incident structure. I realize now I for some reason only mentioned updating the student view incident tracking, so thats my bad, but nonetheless the motivation of the ticket was to fully update the frontend.

Partially a reason these were not caught is that typescript did not catch them even though the IncidentSeverity type was not updated, due to these instances not being hooked into the shared types or due to explicit casting. As you go through and update, please also make sure they are fixed to prevent regression

Copy link
Copy Markdown
Collaborator

@naasanov naasanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also seeing new merge conflicts after other stuff got merged in

Copy link
Copy Markdown
Collaborator

@naasanov naasanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may have Ctrl + F 'd and updated a lot of the backend. That is outside the scope of this ticket and being handled by another ticket, and I believe that is what caused the test failures. You can revert the backend changes

@aileenr19 aileenr19 requested a review from naasanov April 7, 2026 20:04
Copy link
Copy Markdown
Collaborator

@naasanov naasanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@naasanov naasanov merged commit 96cac6f into main Apr 7, 2026
3 checks passed
@naasanov naasanov deleted the aileen/frontend-incidents-table branch April 7, 2026 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Frontend Incidents Update + Table

3 participants