Conversation
…omponent for mobile view
…' into feature/police-view
… information loading
…tionality and passing objects.
naasanov
left a comment
There was a problem hiding this comment.
I was able to Cmd + Shift + F "complaint" in frontend/src and find several places where the frontend was not updated to the new incident structure. I realize now I for some reason only mentioned updating the student view incident tracking, so thats my bad, but nonetheless the motivation of the ticket was to fully update the frontend.
Partially a reason these were not caught is that typescript did not catch them even though the IncidentSeverity type was not updated, due to these instances not being hooked into the shared types or due to explicit casting. As you go through and update, please also make sure they are fixed to prevent regression
frontend/src/app/staff/_components/incident/IncidentTableForm.tsx
Outdated
Show resolved
Hide resolved
frontend/src/app/staff/_components/incident/IncidentTableForm.tsx
Outdated
Show resolved
Hide resolved
frontend/src/app/staff/_components/incident/IncidentTableForm.tsx
Outdated
Show resolved
Hide resolved
…, made expandable text area, and working on refactoring
frontend/src/app/staff/_components/incident/IncidentTableForm.tsx
Outdated
Show resolved
Hide resolved
frontend/src/app/staff/_components/incident/IncidentTableForm.tsx
Outdated
Show resolved
Hide resolved
naasanov
left a comment
There was a problem hiding this comment.
You may have Ctrl + F 'd and updated a lot of the backend. That is outside the scope of this ticket and being handled by another ticket, and I believe that is what caused the test failures. You can revert the backend changes
With the new incident structure, the frontend needs to be updated to match. Additionally, staff need a table to track individual incidents with sorting, filtering, etc. functionality.
Changes:
Closes #246.