Skip to content

Student Styles#248

Merged
naasanov merged 17 commits intomainfrom
megan/student-styles
Apr 4, 2026
Merged

Student Styles#248
naasanov merged 17 commits intomainfrom
megan/student-styles

Conversation

@mmtaylo
Copy link
Copy Markdown
Collaborator

@mmtaylo mmtaylo commented Mar 9, 2026

Styles for the student views must match the Hi-fi mockups in the style guide.

Changes:

  • Added new accordion radix component, utilized by the "Party Registration Info" and "Party Smart Info" components, links to new pages on mobile screens with this new components (from new party and main dashboard pages) to match the UI.
  • Added Party Regi/Party Info components to main student dashboard and updated the main layout for the two columns to match the UI.
  • On all pages (besides new party registration page), adjusted the cards to scroll and have fixed height (so the entire page doesn't scroll), added semantic textual and containing elements (h1, h2, p, main, section), added text styles (page-title, content, subhead-content, etc.).
  • Updated the Registration Tracker component (only having contact name and number).
  • Potentially out-of-scope that might be nice:
    • added in globals.css: a "sub text" that it italicized and opaque for subhead descriptions, noticed this utilized across several pages, might be nice to have.
    • added text colors in globals.css for the text-based classes

Note: I added some mock data since I can't connect to the DB or Docker, attempted to remove all of it, but might have missed some.

Closes #231

@mmtaylo mmtaylo requested a review from naasanov March 9, 2026 19:21
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 10, 2026

Test Results Summary

551 tests  ±0   551 ✅ ±0   38s ⏱️ -1s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit a90d114. ± Comparison against base commit 6735ae5.

♻️ This comment has been updated with latest results.

Copy link
Copy Markdown
Collaborator

@naasanov naasanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflict stuff

Copy link
Copy Markdown
Collaborator

@naasanov naasanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code related changes

Copy link
Copy Markdown
Collaborator

@naasanov naasanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My residence address looks like this
Image

…into megan/student-styles

# Conflicts:
#	frontend/src/app/globals.css
#	frontend/src/app/student/_components/PartyRegistrationForm.tsx
#	frontend/src/app/student/new-party/page.tsx
#	frontend/src/app/student/page.tsx
#	frontend/src/components/ui/tabs.tsx
@naasanov naasanov mentioned this pull request Mar 31, 2026
Copy link
Copy Markdown
Collaborator

@naasanov naasanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@naasanov naasanov merged commit 3e28895 into main Apr 4, 2026
3 checks passed
@naasanov naasanov deleted the megan/student-styles branch April 4, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Student Styles

2 participants