Skip to content

es6 implementation #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

es6 implementation #18

wants to merge 4 commits into from

Conversation

CalebM1987
Copy link

This proposed branch implements this package as a modern es6 module. It uses rollup.js to build the distribution file and also converts it to a commonjs es5 module via babel.

This was created because I could not rollup this module in other modules due to circular dependencies and undefined scopes. This branch offers the following improvements:

  • rewritten as es6
  • distribution file created with rollup resulting in smaller file size
  • no more circular dependencies
  • named exports for Token, Secret, etc
  • added help documentation via jsdoc in the docs folder
  • has a new defaults object to store global configurations for secret, ttl, and versionHex, while still exporting a fernet instance to scope Tokens
  • renamed test.html to index.html and moved into test folder

tests

All tests are passing in Node, however, I could not get sinon-chai to work in the test html file and mocha causes memory leaks (possibly because of missing sinon-chai?).

@csquared
Copy link
Owner

hey @CalebM1987 i'm sorry i missed this -- did you wind up forking or can i still merge?

@dikaso
Copy link

dikaso commented Apr 10, 2024

hey @CalebM1987 i'm sorry i missed this -- did you wind up forking or can i still merge?

He fork it in https://github.com/CalebM1987/fernet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants