Skip to content

Introduce definition factory #504

Introduce definition factory

Introduce definition factory #504

Triggered via pull request June 20, 2024 21:20
Status Failure
Total duration 39s
Artifacts

php.yml

on: pull_request
unit-testing
22s
unit-testing
static-analysis
18s
static-analysis
code-linting
29s
code-linting
Fit to window
Zoom out
Zoom in

Annotations

18 errors and 3 warnings
MoreSpecificReturnType: src/Definition/DefinitionFactory.php#L158
src/Definition/DefinitionFactory.php:158:44: MoreSpecificReturnType: The declared return type 'non-empty-string' for Cspray\AnnotatedContainer\Definition\_home_runner_work_annotated_container_annotated_container_src_Definition_DefinitionFactory_php_146_5819::methodName is more specific than the inferred return type 'string' (see https://psalm.dev/070)
LessSpecificReturnStatement: src/Definition/DefinitionFactory.php#L159
src/Definition/DefinitionFactory.php:159:24: LessSpecificReturnStatement: The type 'string' is more general than the declared return type 'non-empty-string' for Cspray\AnnotatedContainer\Definition\_home_runner_work_annotated_container_annotated_container_src_Definition_DefinitionFactory_php_146_5819::methodName (see https://psalm.dev/129)
UndefinedMethod: src/Definition/DefinitionFactory.php#L212
src/Definition/DefinitionFactory.php:212:40: UndefinedMethod: Method ReflectionType::getName does not exist (see https://psalm.dev/022)
MixedArgument: src/Definition/DefinitionFactory.php#L217
src/Definition/DefinitionFactory.php:217:31: MixedArgument: Argument 1 of interface_exists cannot be class-string|mixed, expecting string (see https://psalm.dev/030)
MixedArgument: src/Definition/DefinitionFactory.php#L217
src/Definition/DefinitionFactory.php:217:65: MixedArgument: Argument 1 of class_exists cannot be class-string|mixed|string, expecting string (see https://psalm.dev/030)
MoreSpecificReturnType: src/Definition/DefinitionFactory.php#L242
src/Definition/DefinitionFactory.php:242:48: MoreSpecificReturnType: The declared return type 'non-empty-string' for Cspray\AnnotatedContainer\Definition\_home_runner_work_annotated_container_annotated_container_src_Definition_DefinitionFactory_php_223_9047::delegateMethod is more specific than the inferred return type 'string' (see https://psalm.dev/070)
LessSpecificReturnStatement: src/Definition/DefinitionFactory.php#L243
src/Definition/DefinitionFactory.php:243:24: LessSpecificReturnStatement: The type 'string' is more general than the declared return type 'non-empty-string' for Cspray\AnnotatedContainer\Definition\_home_runner_work_annotated_container_annotated_container_src_Definition_DefinitionFactory_php_223_9047::delegateMethod (see https://psalm.dev/129)
PossiblyNullReference: src/Definition/DefinitionFactory.php#L267
src/Definition/DefinitionFactory.php:267:63: PossiblyNullReference: Cannot call method getName on possibly null value (see https://psalm.dev/083)
ArgumentTypeCoercion: src/Definition/DefinitionFactory.php#L269
src/Definition/DefinitionFactory.php:269:59: ArgumentTypeCoercion: Argument 1 of Cspray\AnnotatedContainer\Definition\DefinitionFactory::typiphyTypeFromReflectionNamedType expects ReflectionNamedType|null, but parent type ReflectionType|null provided (see https://psalm.dev/193)
MixedAssignment: src/Definition/DefinitionFactory.php#L271
src/Definition/DefinitionFactory.php:271:9: MixedAssignment: Unable to determine the type that $value is being assigned to (see https://psalm.dev/032)
unit-testing
Process completed with exit code 1.
code-linting: src/Definition/DefinitionFactory.php#L291
Closing brace must be on a line by itself
code-linting: src/Function/definitions.php#L39
Only one argument is allowed per line in a multi-line function call
code-linting: src/Function/definitions.php#L39
Only one argument is allowed per line in a multi-line function call
code-linting: src/Exception/WrongTargetForInjectAttribute.php#L24
The closing brace for the class must go on the next line after the body
code-linting: src/Exception/InjectAttributeRequired.php#L17
The closing brace for the class must go on the next line after the body
code-linting: test/Unit/Definition/DefinitionFactoryTest.php#L820
The closing brace for the class must go on the next line after the body
code-linting
Process completed with exit code 1.
static-analysis
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
unit-testing
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
code-linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.