Remove a val in arr and return the length of remaining values #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezkemboi
force-pushed
the
removeelement
branch
from
bc4b1b1 to
3022832
Compare
profnandaa
requested changes
Feb 19, 2020
| const removeElement = require("./solution"); | ||
|
|
||
| describe("remove element", () => { | ||
| it("should remove an element and return its length", () => { |
There was a problem hiding this comment.
should also add a test to show that the array is mutated; coz how about if I just count the elements and return that count?
There was a problem hiding this comment.
The length should be different/less.
There was a problem hiding this comment.
Alright, feedback taken and will work on it.
| * but assigining its num values | ||
| */ | ||
| if (arr[i] != val) { | ||
| arr[counts++] = arr[i] |
There was a problem hiding this comment.
I think this is not correct, take an example:
arr = [1, 2, 4, 2, 5];
val = 2;
// when i = 0, arr[i] != val is true, so
// arr[counts++] = arr[i], basically arr[0] = arr[0], nothing has happened here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@profnandaa almost similar to #9 as suggested in Leetcode.
You can also check on this one if you get some time.
Thanks.