Skip to content

a3-Michael-Lai#107

Open
AzinxtheOnix wants to merge 18 commits into
cs4241-21a:mainfrom
AzinxtheOnix:main
Open

a3-Michael-Lai#107
AzinxtheOnix wants to merge 18 commits into
cs4241-21a:mainfrom
AzinxtheOnix:main

Conversation

@AzinxtheOnix

@AzinxtheOnix AzinxtheOnix commented Sep 28, 2021

Copy link
Copy Markdown

https://a3-michael-lai.herokuapp.com/
Note: Professor gave me a 24 hr extension.

Well then, this project went better than the last. There are two things I wasn't able to fully implement:

  • User accounts that can only edit/delete certain information (instead, all accounts are allowed to edit anything, but at least I got OAuth working)
  • CSS Framework/Template

Instead of panic commiting a late fix like last time, I'll probably make a branch and see what I could do. Heroku definitely would help, as I can easily deploy between two branches. If I finalize a fix, I'll make a comment on it and post a link to the branch. It would be up to you if you want to consider those fixes (but the original submission would remain intact in the main branch).

@AzinxtheOnix

Copy link
Copy Markdown
Author

Also, there was an original issue with the Github OAuth client secret being public, but that's already been patched in the main branch and I just created a new client secret (and deleted the old one).

@AzinxtheOnix

Copy link
Copy Markdown
Author

A very small security fix to the project. Forgot to obfuscate the username and password to the MongoDB database.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant