-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic implementation of OCM 1.2 payloads #5076
base: master
Are you sure you want to change the base?
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
4f33f55
to
f041e87
Compare
97fa98f
to
6af8c62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this is good enough for now: we discover remote endpoints according to specs, but we still send full URIs to remotes. Also the integration tests assume full URIs, so the discovery part is not covered (but was tested independently).
In the future we may reconfigure the test to set the owner's address to localhost:<port>
and pass relative URIs so to trigger discovery (but https
is assumed when contacting the remote, so we'd have to configure TLS on the test as well).
This PR includes:
requirement
in a share will be rejected (a test was added for that).