fix bugs in other mutators

crytic · Jan 27, 2025 · 2295939 · 2295939
1 parent 8b9590d
commit 2295939
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/slither/tools/mutator/mutators/AOR.py b/slither/tools/mutator/mutators/AOR.py
@@ -77,8 +77,10 @@ def _mutate(self) -> Dict:
                             old_str = node.source_mapping.content
                             line_no = node.source_mapping.lines
                             if not line_no[0] in self.dont_mutate_line:
-                                # Replace the expression with true
-                                new_str = f"{old_str.split(ir.type.value)[0]}{op.value}{old_str.split(ir.type.value)[1]}"
+                                halves = old_str.split(ir.type.value)
+                                if len(halves) != 2:
+                                    continue # skip if assembly
+                                new_str = f"{halves[0]}{op.value}{halves[1]}"
                                 create_patch_with_line(
                                     result,
                                     self.in_file,

diff --git a/slither/tools/mutator/mutators/FHR.py b/slither/tools/mutator/mutators/FHR.py
@@ -22,7 +22,7 @@ def _mutate(self) -> Dict:
         for function in self.contract.functions_and_modifiers_declared:
             start = function.source_mapping.start
             stop = start + function.source_mapping.content.find("{")
-            old_str = node.source_mapping.content
+            old_str = function.source_mapping.content
             line_no = function.source_mapping.lines
             if not line_no[0] in self.dont_mutate_line:
                 for value in function_header_replacements:

diff --git a/slither/tools/mutator/mutators/MVIE.py b/slither/tools/mutator/mutators/MVIE.py
@@ -24,7 +24,7 @@ def _mutate(self) -> Dict:
                     # Get the string
                     start = variable.source_mapping.start
                     stop = variable.expression.source_mapping.start
-                    old_str = node.source_mapping.content
+                    old_str = variable.source_mapping.content
                     new_str = old_str[: old_str.find("=")]
                     line_no = variable.node_initialization.source_mapping.lines
                     if not line_no[0] in self.dont_mutate_line:
@@ -44,7 +44,7 @@ def _mutate(self) -> Dict:
                     # Get the string
                     start = variable.source_mapping.start
                     stop = variable.expression.source_mapping.start
-                    old_str = node.source_mapping.content
+                    old_str = variable.source_mapping.content
                     new_str = old_str[: old_str.find("=")]
                     line_no = variable.source_mapping.lines
                     if not line_no[0] in self.dont_mutate_line:

diff --git a/slither/tools/mutator/mutators/ROR.py b/slither/tools/mutator/mutators/ROR.py
@@ -40,7 +40,7 @@ def _mutate(self) -> Dict:
                                 line_no = node.source_mapping.lines
                                 if not line_no[0] in self.dont_mutate_line:
                                     # Replace the expression with true
-                                    new_str = f"{old_str.split(ir.type.value)[0]} {op.value} {old_str.split(ir.type.value)[1]}"
+                                    new_str = f"{old_str.split(ir.type.value)[0]}{op.value}{old_str.split(ir.type.value)[1]}"
                                     create_patch_with_line(
                                         result,
                                         self.in_file,