Lint/UnusedLiteral marks unused nil literals as unused
#560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobodywasishere
force-pushed
the
nobody/unused-nil-literal
branch
from
b3b4f39 to
e5203b1
Compare
|
The unused nil in the failing specs is actually unused, but I'm not sure if there's a better way of writing that to work around it, besides expanding it to a full rescue block. |
|
That's a customary way to write calls ignoring the errors with trailing rescue (there's no other way to do so otherwise), so I reckon these should be ignored. |
|
Closing this for now. Unused |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed this for some reason