Code

Refactors before 1.7 release#555

Code

Merged

Sija merged 29 commits intomastercrystal-ameba/ameba:masterfrom refactors-before-1.7-releasecrystal-ameba/ameba:refactors-before-1.7-releaseCopy head branch name to clipboardJan 30, 2025

+845-817

Commits

Commits on Jan 29, 2025

• eq true -> be_true

  Sija

  committed
  da33d70

  Copy full SHA for da33d70

• Cleanup redundant :nodoc: annotations

  Sija

  committed
  6af9e1c

  Copy full SHA for 6af9e1c

Commits on Jan 30, 2025

• Fix code indentation in specs

  Sija

  committed
  6a70b09

  Copy full SHA for 6a70b09

• Correctly wrap typo suggestions in backticks

  Sija

  committed
  ca5b806

  Copy full SHA for ca5b806

• Change Documentation rule group severity to Convention instead of Warning

  Sija

  committed
  360f7d7

  Copy full SHA for 360f7d7

• Change Documentation/DocumentationAdmonition rule severity to Warning

  Sija

  committed
  7c38b88

  Copy full SHA for 7c38b88

• Add missing describe blocks

  Sija

  committed
  954493f

  Copy full SHA for 954493f

• Keep subject assignments within the describe block

  Sija

  committed
  68c3852

  Copy full SHA for 68c3852

• Refactor formatters’ specs

  Sija

  committed
  565988e

  Copy full SHA for 565988e

• Make some internal methods private

  Sija

  committed
  34966ed

  Copy full SHA for 34966ed

• Remove prefer_name_location: true since it doesn’t change anything

  Sija

  committed
  b3884e9

  Copy full SHA for b3884e9

• Remove some ameba:disable Lint/NotNil directives

  Sija

  committed
  0be073f

  Copy full SHA for 0be073f

• Return early in Lint/Formatting if source code is empty

  Sija

  committed
  fb87aa3

  Copy full SHA for fb87aa3

• Cleanup AST::Reference spec

  Sija

  committed
  78c0f76

  Copy full SHA for 78c0f76

• Add Rule::Lint::Typos#fail_on_missing_bin? option

  Sija

  committed
  9d0d564

  Copy full SHA for 9d0d564

• eq nil -> be_nil

  Sija

  committed
  69f9f8c

  Copy full SHA for 69f9f8c

• Move ecr_supported? macro to the top of the module

  Sija

  committed
  eaeebd9

  Copy full SHA for eaeebd9

• Add Source#ecr? method

  Sija

  committed
  fb80d37

  Copy full SHA for fb80d37

• Use path getter instead

  Sija

  committed
  71cc07f

  Copy full SHA for 71cc07f

• Make some methods private

  Sija

  committed
  2f07b29

  Copy full SHA for 2f07b29

• Add additional spec assertion

  Sija

  committed
  fe8fba5

  Copy full SHA for fe8fba5

• Wrap long lines for better readability

  Sija

  committed
  170fbf6

  Copy full SHA for 170fbf6

• Refactor visitors a bit

  Sija

  committed
  131c35e

  Copy full SHA for 131c35e

• Use Enabled: true in the rules’ YAML configuration example sections

  Sija

  committed
  6ef291d

  Copy full SHA for 6ef291d

• Several readability related refactors

  Sija

  committed
  a961126

  Copy full SHA for a961126

• Add backticks around Crystal keywords in some more comments and messages

  Sija

  committed
  2e8c287

  Copy full SHA for 2e8c287

• Move describe block outside of Ameba.ecr_supported? call

  Sija

  committed
  074d86e

  Copy full SHA for 074d86e

• Tweak rules’ docs and messages

  Sija

  committed
  6b19c0f

  Copy full SHA for 6b19c0f

• Use variant of heredoc without interpolation wherever possible

  Sija

  committed
  cd144e9

  Copy full SHA for cd144e9