Add Lint/UnusedGenericOrUnion
#537
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobodywasishere
commented
Jan 15, 2025
|
|
nobodywasishere
changed the title
Lint/UnusedPathGenericOrUnionLint/UnusedTypeOrConstant
veelenga
reviewed
Jan 18, 2025
|
I'd reconsider the original name. This rule is about references to types, i.e. a path. The term Also I'm not sure it makes sense to include paths to constants because they actually have the side effect of initializing the constant's value. |
|
There's no way to differentiate paths that point to class names vs constants without semantic analysis, so we'll need to drop support for paths in general then. I'll rename to |
nobodywasishere
force-pushed
the
nobody/unused-path-generic-or-union
branch
from
1bdfbc9 to
bb1ef05
Compare
nobodywasishere
changed the title
Lint/UnusedTypeOrConstantLint/GenericOrUnion
nobodywasishere
changed the title
Lint/GenericOrUnionLint/UnusedGenericOrUnion
These are the only other nodes allowed in type unions (excluding "self?", as it can point to a method)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to
Lint/UnusedLiteralandLint/UnusedComparison. Not too fond of the name so any suggestions are welcome.