Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lint/RequireParentheses #510

Merged

Conversation

nobodywasishere
Copy link
Contributor

Closes #313

spec/ameba/rule/lint/logical_without_paren_spec.cr Outdated Show resolved Hide resolved
src/ameba/rule/lint/logical_without_paren.cr Outdated Show resolved Hide resolved
@Sija Sija added the rule label Nov 24, 2024
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
src/ameba/rule/lint/logical_without_paren.cr Outdated Show resolved Hide resolved
src/ameba/rule/lint/logical_without_paren.cr Outdated Show resolved Hide resolved
src/ameba/rule/lint/logical_without_paren.cr Outdated Show resolved Hide resolved
src/ameba/rule/lint/logical_without_paren.cr Outdated Show resolved Hide resolved
spec/ameba/rule/lint/logical_without_paren_spec.cr Outdated Show resolved Hide resolved
spec/ameba/rule/lint/logical_without_paren_spec.cr Outdated Show resolved Hide resolved
nobodywasishere and others added 6 commits November 24, 2024 15:05
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
spec/ameba/rule/lint/logical_without_paren_spec.cr Outdated Show resolved Hide resolved
spec/ameba/rule/lint/logical_without_paren_spec.cr Outdated Show resolved Hide resolved
@nobodywasishere nobodywasishere changed the title Add Lint/LogicalWithoutParenthesis Add Lint/RequireParentheses Nov 25, 2024
Copy link
Member

@Sija Sija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sija Sija added this to the 1.7.0 milestone Nov 25, 2024
@Sija
Copy link
Member

Sija commented Nov 25, 2024

I'll merge it once v1.6.4 is out (which gonna be soon).

@Sija Sija requested a review from veelenga November 25, 2024 01:05
Copy link
Member

@veelenga veelenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sija Sija merged commit 9175e64 into crystal-ameba:master Nov 26, 2024
4 checks passed
@nobodywasishere nobodywasishere deleted the nobody/logical-without-paren branch November 26, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn on expressions that contain logical operators but no braces
3 participants