Coq small fixes #1108
Merged
Coq small fixes #1108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmester0
force-pushed
the
coq-small-fixes
branch
5 times, most recently
from
f7cb54f to
e39e7cd
Compare
Closed
cmester0
commented
Nov 19, 2024
cmester0
commented
Nov 19, 2024
cmester0
commented
Nov 19, 2024
cmester0
force-pushed
the
coq-small-fixes
branch
3 times, most recently
from
e04856e to
5afea93
Compare
cmester0
changed the base branch from
main
to
coq-generic-printer-annotated-core-lib
cmester0
force-pushed
the
coq-small-fixes
branch
5 times, most recently
from
a4ab210 to
ddec63c
Compare
|
Let's look at that together to chat about CI, and merge |
Base automatically changed from
coq-generic-printer-annotated-core-lib
to
main
November 28, 2024 13:32
|
Lasse and I are looking at that PR right now |
cmester0
force-pushed
the
coq-small-fixes
branch
from
0150344 to
ff429a0
Compare
W95Psp
force-pushed
the
coq-small-fixes
branch
from
ff429a0 to
197d1a3
Compare
cmester0
commented
Nov 28, 2024
|
@W95Psp The Coq code should work now. Seems to be an issue with |
|
@W95Psp please have a look at this. |
cmester0
commented
Feb 6, 2025
|
It would be good to get this merged, the tests are nice, however, if we do not want to fix the Nix setup now, I can remove that part. Some of the features in this PR are related to the issues Andrei Listochkin is experiencing with the Coq backend. |
|
This somewhat works now. We can do some follow up PRs for structuring things or adding more tests. |
karthikbhargavan
approved these changes
May 5, 2025
cmester0
removed
the
waiting-on-reviewer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.